Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parcel giving 404 on localhost:1234 #354

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

aatmanvaidya
Copy link
Collaborator

This PR fixes the error of parcel giving us a 404 error on localhost:1234

The front end of the browser extension can be just loaded using the options.jsx file in the plugin/src folder.
The error occurring was when we tried to run just the frontend using the npm run start:options, which triggers this command parcel src/options.jsx

To fix it we have to actually run the options.html file using parcel, in which we pass the options.jsx file.
now the frontend runs on localhost:1234

@ghost
Copy link

ghost commented Sep 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@dennyabrain
Copy link
Contributor

aah! nice catch. Merging.

@dennyabrain dennyabrain merged commit a42500e into tattle-made:main Sep 4, 2023
2 checks passed
@dennyabrain dennyabrain self-requested a review September 4, 2023 08:48
@dennyabrain dennyabrain added bug Something isn't working level: ticket: bug tickets that are fixing bugs in existing codebase labels Sep 4, 2023
@aatmanvaidya aatmanvaidya deleted the parcel-fix branch September 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working level: ticket: bug tickets that are fixing bugs in existing codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants